feat(pkg/da): Extract min share creation into separate function for convenience #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
approved these changes
Mar 13, 2023
MSevey
requested review from
a team and
cmwaters
and removed request for
a team
cmwaters
approved these changes
Mar 13, 2023
Codecov Report
@@ Coverage Diff @@
## main #1476 +/- ##
=======================================
Coverage ? 49.21%
=======================================
Files ? 79
Lines ? 4480
Branches ? 0
=======================================
Hits ? 2205
Misses ? 2091
Partials ? 184
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rootulp
approved these changes
Mar 13, 2023
Wondertan
reviewed
Mar 13, 2023
evan-forbes
pushed a commit
that referenced
this pull request
Mar 21, 2023
…onvenience (#1476) This PR extracts min share creation into an exported function so that celestia-node can depend on it canonically without duplicating code and risking error. Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Merged
5 tasks
evan-forbes
added a commit
that referenced
this pull request
Mar 21, 2023
…onvenience (#1476) (#1515) ## Overview cherry picks #1476 onto v0.13.0, which is now a fork of the v0.12.x branch ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords Co-authored-by: rene <41963722+renaynay@users.noreply.github.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts min share creation into an exported function so that celestia-node can depend on it canonically without duplicating code and risking error.