Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove packr2 #1479

Merged
merged 1 commit into from
Mar 13, 2023
Merged

chore: remove packr2 #1479

merged 1 commit into from
Mar 13, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 13, 2023

Closes #1478

Testing

The before / after binaries are the exact same size

-rwxr-xr-x    1 rootulp  staff  81822242 Mar 13 11:58 celestia-appd-after
-rwxr-xr-x    1 rootulp  staff  81822242 Mar 13 11:57 celestia-appd-before

Based on a ./celestia-appd --help invocation, they appear to behave identically

@rootulp rootulp self-assigned this Mar 13, 2023
@rootulp rootulp marked this pull request as ready for review March 13, 2023 16:12
@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Mar 13, 2023
@rootulp rootulp merged commit ceff1de into celestiaorg:main Mar 13, 2023
@rootulp rootulp deleted the rp/remove-packr2 branch March 13, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gobuffalo/packr used in make build is not maintained anymore
2 participants