Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Sanaz as NMT wrapper code owner #1482

Merged
merged 1 commit into from
Mar 13, 2023
Merged

chore: add Sanaz as NMT wrapper code owner #1482

merged 1 commit into from
Mar 13, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 13, 2023 •
edited

Inspired by #1481 (review) 馃槅

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Mar 13, 2023
@rootulp rootulp requested a review from staheri14 March 13, 2023 20:31
@rootulp rootulp self-assigned this Mar 13, 2023
@MSevey MSevey requested a review from a team March 13, 2023 20:32
evan-forbes
evan-forbes approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah! I'm still of the opinion that we should try to add more folks. 3 active contributors + leadership should be the minimum imo

@rootulp
Copy link
Collaborator Author

rootulp commented Mar 13, 2023

It would be nice if each directory had at least 2 owners to reduce bus factor. Will merge this as-is and ppl can add themselves as owners to directories as they work on them.

@rootulp rootulp merged commit 424f361 into main Mar 13, 2023
@rootulp rootulp deleted the rootulp-patch-1 branch March 13, 2023 20:53
@staheri14
Copy link
Contributor

Thanks @rootulp for this! 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@staheri14 staheri14 Awaiting requested review from staheri14

Assignees

@rootulp rootulp

Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rootulp @staheri14 @evan-forbes