feat!: specify utia as denom for gov module genesis
#1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
reviewed
Mar 13, 2023
Comment on lines
+22
to
+26
| // HACKHACK explicitly ignore the error returned from json.Unmarshal because | ||
| // the error is a failure to unmarshal the string StartingProposalId as a | ||
| // uint which is unrelated to the test here. | ||
| //nolint:errcheck | ||
| json.Unmarshal(raw, &govGenesisState) |
There was a problem hiding this comment.
[optional]
this comment is good but also why not explicitly ignore the error and get rid of the no lint?
Suggested change
| // HACKHACK explicitly ignore the error returned from json.Unmarshal because | |
| // the error is a failure to unmarshal the string StartingProposalId as a | |
| // uint which is unrelated to the test here. | |
| //nolint:errcheck | |
| json.Unmarshal(raw, &govGenesisState) | |
| // HACKHACK explicitly ignore the error returned from json.Unmarshal because | |
| // the error is a failure to unmarshal the string StartingProposalId as a | |
| // uint which is unrelated to the test here. | |
| _ = json.Unmarshal(raw, &govGenesisState) |
There was a problem hiding this comment.
we just need to get rid of the : in the first image since we're not declaring anything
There was a problem hiding this comment.
oof how did I miss that. Can do in a follow-up PR.
evan-forbes
approved these changes
Mar 13, 2023
Merged
rootulp
added a commit
that referenced
this pull request
Mar 14, 2023
Addresses this feedback: #1484 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue identified in https://github.com/celestiaorg/itn-doc/issues/168
Testing
Verified genesis.json contains
utiain the gov module in this diff