Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve CreateCommitment docs #1508

Merged
merged 1 commit into from
Mar 21, 2023
Merged

docs: improve CreateCommitment docs #1508

merged 1 commit into from
Mar 21, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 20, 2023 •
edited

Update CreateCommitment docs to reflect:

  1. there isn't one commitment for multiple blobs (this was briefly introduced when we added PayForBlobs but reverted in Revert MultiShareCommitment and include each ShareCommitment in the PFB #1231)
  2. the duplicate namespace ID prefix to match up with NMT subtree roots

@rootulp rootulp added the documentation Improvements or additions to documentation label Mar 20, 2023
@rootulp rootulp self-assigned this Mar 20, 2023
@MSevey MSevey requested review from a team and MSevey and removed request for a team March 20, 2023 16:03
@rootulp rootulp merged commit 801ce1a into celestiaorg:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSevey MSevey MSevey approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@rootulp rootulp

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rootulp @MSevey @evan-forbes