Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move check closer to tree population #1523

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 22, 2023

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Mar 22, 2023
@rootulp rootulp requested a review from staheri14 March 22, 2023 17:47
@rootulp rootulp self-assigned this Mar 22, 2023
@MSevey MSevey requested a review from a team March 22, 2023 17:48
@codecov-commenter
Copy link

Codecov Report

Merging #1523 (e838b2f) into main (71ab161) will decrease coverage by 0.83%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1523      +/-   ##
==========================================
- Coverage   50.70%   49.88%   -0.83%     
==========================================
  Files          82       82              
  Lines        4723     4811      +88     
==========================================
+ Hits         2395     2400       +5     
- Misses       2134     2193      +59     
- Partials      194      218      +24     
Impacted Files Coverage Δ
pkg/proof/proof.go 65.35% <66.66%> (-2.11%) ⬇️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp rootulp enabled auto-merge (squash) March 22, 2023 20:09
Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rootulp rootulp merged commit 74a3e4b into celestiaorg:main Mar 23, 2023
@rootulp rootulp deleted the rp/share-proof-check branch March 23, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanity check should be done immediately after tree creation
3 participants