Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: panic on too short data #1524

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 22, 2023

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Mar 22, 2023
@rootulp rootulp requested a review from staheri14 as a code owner March 22, 2023 18:00
@rootulp rootulp self-assigned this Mar 22, 2023
@MSevey MSevey requested a review from a team March 22, 2023 18:00
staheri14
staheri14 previously approved these changes Mar 22, 2023
pkg/wrapper/nmt_wrapper.go Outdated Show resolved Hide resolved
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
@rootulp rootulp enabled auto-merge (squash) March 22, 2023 20:19
@rootulp rootulp requested a review from staheri14 March 22, 2023 20:19
@MSevey MSevey requested a review from a team March 22, 2023 20:19
@codecov-commenter
Copy link

Codecov Report

Merging #1524 (c935255) into main (71ab161) will decrease coverage by 0.77%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1524      +/-   ##
==========================================
- Coverage   50.70%   49.94%   -0.77%     
==========================================
  Files          82       82              
  Lines        4723     4817      +94     
==========================================
+ Hits         2395     2406      +11     
- Misses       2134     2193      +59     
- Partials      194      218      +24     
Impacted Files Coverage Δ
pkg/wrapper/nmt_wrapper.go 79.54% <100.00%> (+2.04%) ⬆️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pkg/wrapper/nmt_wrapper.go Show resolved Hide resolved
@rootulp rootulp merged commit 7c1a237 into celestiaorg:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrapper Push function will panic if the data is invalid
4 participants