Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: public key crypto specs #1553

Merged
merged 6 commits into from
Apr 13, 2023
Merged

docs: public key crypto specs #1553

merged 6 commits into from
Apr 13, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 28, 2023 •
edited

Closes #1440

@rootulp rootulp added the specs directly relevant to the specs label Mar 28, 2023
@rootulp rootulp self-assigned this Mar 28, 2023
@github-actions
Copy link

github-actions bot commented Mar 28, 2023 •
edited

PR Preview Action a15cff9
🚀 Deployed preview to https://celestiaorg.github.io/celestia-app/pr-preview/pr-1553/
on branch gh-pages at 2023-04-10 16:47 UTC

@rootulp rootulp marked this pull request as ready for review April 6, 2023 19:51
adlerjohn
adlerjohn reviewed Apr 7, 2023
View reviewed changes
specs/src/specs/data_structures.md Outdated Show resolved Hide resolved
specs/src/specs/data_structures.md Outdated Show resolved Hide resolved
@rootulp @adlerjohn
Update specs/src/specs/data_structures.md
fb26ad1 
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
@MSevey MSevey requested a review from a team April 7, 2023 14:25
rootulp
rootulp commented Apr 7, 2023
View reviewed changes
specs/src/specs/data_structures.md
Addresses have a length of 32 bytes.
| name | type | description |
|--------------|------------|-------------------------------------------------------------------------|
| `AccAddress` | `[20]byte` | AccAddress a wrapper around bytes meant to represent an account address |
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[for reviewers] inspired by https://github.com/celestiaorg/cosmos-sdk/blob/f19e20459b8bcf195167ad256de5a6ca6edc41f5/types/address.go#L130-L132

@rootulp rootulp requested a review from adlerjohn April 7, 2023 19:11
@MSevey MSevey requested a review from a team April 10, 2023 16:47
@rootulp rootulp requested a review from liamsi April 10, 2023 16:47
cmwaters
cmwaters approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

specs/src/specs/public_key_cryptography.md Show resolved Hide resolved
evan-forbes
evan-forbes approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rootulp rootulp merged commit 64192cf into main Apr 13, 2023
28 checks passed
@rootulp rootulp deleted the rp/pub-key-specs branch April 13, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

@MSevey MSevey Awaiting requested review from MSevey

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

@liamsi liamsi Awaiting requested review from liamsi liamsi is a code owner

Assignees

@rootulp rootulp

Labels
specs directly relevant to the specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

specs: public keys
5 participants
@rootulp @adlerjohn @liamsi @cmwaters @evan-forbes