Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: versioned namespaces #1557

Merged
merged 5 commits into from
Mar 29, 2023
Merged

feat!: versioned namespaces #1557

merged 5 commits into from
Mar 29, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 29, 2023 •
edited

This PR merges the feature branch into main. It contains
#1419
#1529
#1550

@rootulp rootulp added consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules warn:api breaking item will be break an API and require a major bump labels Mar 29, 2023
@rootulp rootulp self-assigned this Mar 29, 2023
@rootulp rootulp marked this pull request as ready for review March 29, 2023 08:35
@github-actions
Copy link

PR Preview Action v1.3.0
🚀 Deployed preview to https://celestiaorg.github.io/celestia-app/pr-preview/pr-1557/
on branch gh-pages at 2023-03-29 08:35 UTC

@rootulp rootulp requested review from cmwaters and removed request for adlerjohn, liamsi and MSevey March 29, 2023 08:35
@rootulp rootulp added this to the Mainnet milestone Mar 29, 2023
evan-forbes
evan-forbes approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!! for posterity, we are :shipit:, then plan finish off any of the tiny remaining feedback things in future PRs

@rootulp rootulp merged commit 4dab3b4 into main Mar 29, 2023
@rootulp rootulp deleted the feat/versioned-namespaces branch March 29, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@staheri14 staheri14 Awaiting requested review from staheri14

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@rootulp rootulp

Labels
consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules warn:api breaking item will be break an API and require a major bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rootulp @evan-forbes