Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: account for namespace version and 32 byte namespace id #1561

Merged
merged 1 commit into from
Mar 29, 2023
Merged

docs: account for namespace version and 32 byte namespace id #1561

merged 1 commit into from
Mar 29, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 29, 2023

Closes #1560

@rootulp rootulp added the documentation Improvements or additions to documentation label Mar 29, 2023
@rootulp rootulp self-assigned this Mar 29, 2023
@MSevey MSevey requested review from a team and mojtaba-esk and removed request for a team March 29, 2023 09:44
@rootulp rootulp merged commit b6acf86 into celestiaorg:main Mar 29, 2023
@rootulp rootulp deleted the rp/share-docs branch March 29, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@mojtaba-esk mojtaba-esk Awaiting requested review from mojtaba-esk mojtaba-esk is a code owner automatically assigned from celestiaorg/celestia-core

Assignees

@rootulp rootulp

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update shares/doc.go to account for 1 byte namespace version + 32 byte namespace ID
2 participants
@rootulp @evan-forbes