Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove min/max square size params #1567

Merged
merged 3 commits into from
Apr 4, 2023
Merged

chore!: remove min/max square size params #1567

merged 3 commits into from
Apr 4, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 30, 2023

Closes #1380

@rootulp rootulp added the warn:api breaking item will be break an API and require a major bump label Mar 30, 2023
@rootulp rootulp self-assigned this Mar 30, 2023
@rootulp rootulp added this to the Mainnet milestone Mar 30, 2023
@MSevey MSevey requested review from a team and cmwaters and removed request for a team March 30, 2023 13:14
@MSevey MSevey requested a review from a team March 31, 2023 08:07
evan-forbes
evan-forbes previously approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 👍

@rootulp rootulp enabled auto-merge (squash) March 31, 2023 14:41
@MSevey MSevey requested a review from a team March 31, 2023 14:41
cmwaters
cmwaters approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rootulp rootulp requested a review from evan-forbes April 3, 2023 21:30
@rootulp rootulp enabled auto-merge (squash) April 3, 2023 21:30
@rootulp rootulp merged commit 41ebe6b into celestiaorg:main Apr 4, 2023
@rootulp rootulp deleted the rp/remove-blob-square-params branch April 4, 2023 17:10
@rootulp rootulp mentioned this pull request Apr 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@rootulp rootulp

Labels
warn:api breaking item will be break an API and require a major bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the unused min and max square size params
3 participants
@rootulp @cmwaters @evan-forbes