feat: add a tmp dir to the single node script #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
previously approved these changes
Mar 31, 2023
Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
rootulp
approved these changes
Mar 31, 2023
evan-forbes
reviewed
Apr 3, 2023
Comment on lines
-63
to
+65
| # Start a single node devnet | ||
| # Start a single node devnet using the pre-installed celestia app | ||
| ./scripts/single-node.sh | ||
|
|
||
| # Build and start a single node devnet | ||
| ./scripts/build-run-single-node.sh |
There was a problem hiding this comment.
I'd be fine with only keeping the build and run, since I doubt anyone would need to rerun the script without building
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a simple change to the single node script to use a randomly generated tmp directory instead of the default directory.
Overview
Checklist