Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin version of celestiaorg/.github workflows and actions #1595

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

smuu
Copy link
Member

@smuu smuu commented Apr 3, 2023

Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
@smuu smuu requested a review from evan-forbes as a code owner April 3, 2023 14:37
@MSevey MSevey requested review from a team and staheri14 and removed request for a team April 3, 2023 14:37
@smuu smuu self-assigned this Apr 3, 2023
Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Does a related GitHub issue exist for this pull request? It would be helpful to include a link to provide context on why a specific version was chosen over the main branch.

@@ -31,16 +31,16 @@ jobs:

# hadolint lints the Dockerfile
hadolint:
uses: celestiaorg/.github/.github/workflows/reusable_dockerfile_lint.yml@main # yamllint disable-line rule:line-length
Copy link
Contributor

@staheri14 staheri14 Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Optional] To make it easier to update the version value in the future, we may define a constant for the version number and reference it throughout the file instead of hard-coding the version number in multiple places.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, why do we do this for all of our github actions? do github actions allow for such a thing? that would be nice since I couldn't find an instance where we need different versions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never seen someone does this. I think it's not even possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Bidon15 Bidon15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a description 🙏
Otherwise, LGTM

@smuu
Copy link
Member Author

smuu commented Apr 4, 2023

LGTM! Does a related GitHub issue exist for this pull request? It would be helpful to include a link to provide context on why a specific version was chosen over the main branch.

Updated PR description

Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rootulp rootulp changed the title feat: pin version of common workflows and actions chore: pin version of celestiaorg/.github workflows and actions Apr 4, 2023
Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a link to the GH issue, LGTM!

@rootulp rootulp merged commit 0334749 into celestiaorg:main Apr 5, 2023
@smuu smuu deleted the feature/pin-common-workflow-version branch April 5, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants