-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pin version of celestiaorg/.github
workflows and actions
#1595
chore: pin version of celestiaorg/.github
workflows and actions
#1595
Conversation
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Does a related GitHub issue exist for this pull request? It would be helpful to include a link to provide context on why a specific version was chosen over the main branch.
@@ -31,16 +31,16 @@ jobs: | |||
|
|||
# hadolint lints the Dockerfile | |||
hadolint: | |||
uses: celestiaorg/.github/.github/workflows/reusable_dockerfile_lint.yml@main # yamllint disable-line rule:line-length |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Optional] To make it easier to update the version value in the future, we may define a constant for the version number and reference it throughout the file instead of hard-coding the version number in multiple places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, why do we do this for all of our github actions? do github actions allow for such a thing? that would be nice since I couldn't find an instance where we need different versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never seen someone does this. I think it's not even possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These might be relevant:
- Defining environment variables for a single workflow https://docs.github.com/en/actions/learn-github-actions/variables#defining-environment-variables-for-a-single-workflow
- Defining configuration variables for multiple workflows: https://docs.github.com/en/actions/learn-github-actions/variables#defining-configuration-variables-for-multiple-workflows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a description 🙏
Otherwise, LGTM
Updated PR description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
celestiaorg/.github
workflows and actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding a link to the GH issue, LGTM!
Tracked by: celestiaorg/devops#140