Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: rename RowsRoots => RowRoots #1611

Merged
merged 1 commit into from
Apr 12, 2023
Merged

chore!: rename RowsRoots => RowRoots #1611

merged 1 commit into from
Apr 12, 2023

Conversation

amityadav0
Copy link
Contributor

@amityadav0 amityadav0 commented Apr 11, 2023 •
edited

Overview

Rename RowsRoots to RowRoots to conform with ColumnRoots.

@MSevey MSevey requested review from a team and rootulp and removed request for a team April 11, 2023 16:06
@rootulp rootulp changed the title typo: RowsRoots chore!: rename RowsRoots => RowRoots Apr 11, 2023
rootulp
rootulp approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@amityadav0 amityadav0 mentioned this pull request Apr 12, 2023
Closed
evan-forbes
evan-forbes approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @amityadav0 !

@evan-forbes evan-forbes merged commit 29563f7 into celestiaorg:main Apr 12, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@amityadav0 amityadav0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typo: RowsRoots
3 participants
@amityadav0 @rootulp @evan-forbes