Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: explicitly set IgnoreMaxNamespace: true #1612

Merged
merged 1 commit into from
Apr 14, 2023
Merged

chore: explicitly set IgnoreMaxNamespace: true #1612

merged 1 commit into from
Apr 14, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Apr 11, 2023

Closes #1450

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Apr 11, 2023
@rootulp rootulp self-assigned this Apr 11, 2023
@rootulp rootulp marked this pull request as ready for review April 13, 2023 21:10
staheri14
staheri14 approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rootulp rootulp enabled auto-merge (squash) April 13, 2023 22:34
evan-forbes
evan-forbes approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this! I think its a large improvement from a readability point of view

@rootulp rootulp merged commit 907fd10 into celestiaorg:main Apr 14, 2023
25 checks passed
@rootulp rootulp deleted the rp/explicit-ignore-max-ns branch April 14, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staheri14 staheri14 staheri14 approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@rootulp rootulp

Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Utilize IgnoreMaxNs when using nmt
3 participants
@rootulp @staheri14 @evan-forbes