Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove evidence namespace #1619

Merged
merged 4 commits into from
Apr 14, 2023
Merged

chore: remove evidence namespace #1619

merged 4 commits into from
Apr 14, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Apr 11, 2023

Closes #1081

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Apr 11, 2023
@rootulp rootulp added this to the Mainnet milestone Apr 11, 2023
@rootulp rootulp self-assigned this Apr 11, 2023
@github-actions
Copy link

github-actions bot commented Apr 11, 2023

PR Preview Action 6a9506a
🚀 Deployed preview to https://celestiaorg.github.io/celestia-app/pr-preview/pr-1619/
on branch gh-pages at 2023-04-14 07:57 UTC

@rootulp
Copy link
Collaborator Author

rootulp commented Apr 13, 2023

idk why some CI tasks was cancelled

@rootulp rootulp marked this pull request as ready for review April 13, 2023 18:53
@rootulp rootulp requested review from cmwaters and removed request for adlerjohn, liamsi and MSevey April 13, 2023 19:26
@cmwaters
Copy link
Contributor

Is it likely that the evidence namespace will come back?

@MSevey MSevey requested a review from a team April 14, 2023 07:57
@codecov-commenter
Copy link

Codecov Report

Merging #1619 (de6bff3) into main (dd19531) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1619   +/-   ##
=======================================
  Coverage   49.17%   49.17%           
=======================================
  Files          84       84           
  Lines        4948     4948           
=======================================
  Hits         2433     2433           
  Misses       2277     2277           
  Partials      238      238           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp
Copy link
Collaborator Author

rootulp commented Apr 14, 2023

Is it likely that the evidence namespace will come back?

My impression is that evidence was originally moved from the Block struct to the data square to enable light clients to sample it rather than download it entirely. From in-person conversations during the Paris on-site, it seems like Evidence is small so we assume that light clients will be able to download it entirely. I think it's unlikely we move it back from the Block to the data square unless we observe that it is too large for light clients to download.

@rootulp rootulp merged commit afc29fe into main Apr 14, 2023
27 of 28 checks passed
@rootulp rootulp deleted the rp/remove-evidence-namespace branch April 14, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing EvidenceNamespace
4 participants