feat!: max namespace version for parity namespace #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes celestiaorg#1587 Motivated by an effort to bump celestia-node's dependency on celestia-app. Will cut a new v0.14.x RC after this merges and also cherry-pick this to main. Can split this into multiple PRs if requested. 1. Export `NewShare` 2. Modify parity namespace to use the max namespace version so that the NMT feature `ignoreMaxNamespace` works as expected Follow-ups: - celestiaorg#1610 (not blocking the upgrade so spinning out)
rootulp
added
the
warn:api breaking
rootulp
changed the title
rootulp
requested review from
evan-forbes,
liamsi,
adlerjohn and
MSevey
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1627 +/- ##
==========================================
- Coverage 49.18% 49.04% -0.14%
==========================================
Files 84 85 +1
Lines 4949 4963 +14
==========================================
Hits 2434 2434
- Misses 2277 2290 +13
- Partials 238 239 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cmwaters
approved these changes
Apr 17, 2023
evan-forbes
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-apply #1590 against
main