Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: address adr-gen feedback #1632

Merged
merged 1 commit into from
Apr 17, 2023
Merged

chore: address adr-gen feedback #1632

merged 1 commit into from
Apr 17, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Apr 17, 2023

Addresses #1599 (review)

Testing

$ make adr-gen

$ git status
On branch rp/adr-gen
Your branch is up to date with 'origin/rp/adr-gen'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	docs/architecture/adr-template.md

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Apr 17, 2023
@rootulp rootulp self-assigned this Apr 17, 2023
@MSevey MSevey requested review from a team and MSevey and removed request for a team April 17, 2023 20:03
@rootulp rootulp enabled auto-merge (squash) April 17, 2023 20:04
rach-id
rach-id approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know this existed :D

@rootulp rootulp merged commit c5ae8ac into celestiaorg:main Apr 17, 2023
25 checks passed
@rootulp rootulp deleted the rp/adr-gen branch April 17, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rach-id rach-id rach-id approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

@MSevey MSevey Awaiting requested review from MSevey MSevey is a code owner automatically assigned from celestiaorg/celestia-core

Assignees

@rootulp rootulp

Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rootulp @rach-id @evan-forbes