Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pkg/shares): Add length of share to err message for SequenceLen #1634

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

renaynay
Copy link
Member

Will probably help for debugging.

@MSevey MSevey requested a review from a team April 18, 2023 14:57
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

Codecov Report

Merging #1634 (a1b3397) into main (d5c20a0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1634      +/-   ##
==========================================
+ Coverage   49.04%   49.05%   +0.01%     
==========================================
  Files          85       85              
  Lines        4963     4964       +1     
==========================================
+ Hits         2434     2435       +1     
  Misses       2290     2290              
  Partials      239      239              
Impacted Files Coverage Δ
pkg/shares/shares.go 74.46% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp rootulp merged commit 952edae into celestiaorg:main Apr 18, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants