Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce DefaultMinGasPrice to appconsts #1642

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Conversation

cmwaters
Copy link
Contributor

Uses a constant in th appconsts package for the DefaultMinGasPrice that users can import.

@MSevey MSevey requested review from a team and mojtaba-esk and removed request for a team April 21, 2023 12:15
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov-commenter
Copy link

Codecov Report

Merging #1642 (fe6c6bf) into main (11374a6) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
+ Coverage   50.89%   50.96%   +0.06%     
==========================================
  Files          92       92              
  Lines        5739     5751      +12     
==========================================
+ Hits         2921     2931      +10     
- Misses       2518     2520       +2     
  Partials      300      300              
Impacted Files Coverage Δ
testing/txsim/send.go 89.65% <ø> (ø)
app/write_square.go 92.98% <100.00%> (ø)
pkg/inclusion/paths.go 100.00% <100.00%> (ø)
pkg/shares/non_interactive_defaults.go 100.00% <100.00%> (ø)
pkg/shares/share_splitting.go 61.73% <100.00%> (ø)
testing/txsim/account.go 67.44% <100.00%> (ø)
x/blob/types/payforblob.go 71.42% <100.00%> (-0.42%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cmwaters cmwaters merged commit 8c1fcb5 into main Apr 23, 2023
28 checks passed
@cmwaters cmwaters deleted the cal/gas-price-min branch April 23, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants