Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rawDataStartIndex method in share package #1646

Conversation

Manav-Aggarwal
Copy link
Member

@Manav-Aggarwal Manav-Aggarwal commented Apr 23, 2023

Overview

Refactors rawDataStartIndex using fewer lines of code and removing unreachable code.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Manav-Aggarwal Manav-Aggarwal self-assigned this Apr 23, 2023
@Manav-Aggarwal Manav-Aggarwal marked this pull request as ready for review April 23, 2023 20:21
@Manav-Aggarwal Manav-Aggarwal added refactor optional label for items that are related to implementation work and do not change functionality share encoding labels Apr 23, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1646 (f3925f1) into main (8c1fcb5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1646      +/-   ##
==========================================
+ Coverage   50.96%   50.98%   +0.01%     
==========================================
  Files          92       92              
  Lines        5751     5749       -2     
==========================================
  Hits         2931     2931              
+ Misses       2520     2519       -1     
+ Partials      300      299       -1     
Impacted Files Coverage Δ
pkg/shares/shares.go 75.53% <100.00%> (+1.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@evan-forbes evan-forbes merged commit 309c650 into celestiaorg:main Apr 24, 2023
24 checks passed
@Manav-Aggarwal Manav-Aggarwal deleted the manav/refactor_raw_data_start_index branch April 24, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor optional label for items that are related to implementation work and do not change functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants