Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: consolidate test package #1647

Merged
merged 1 commit into from
Apr 24, 2023
Merged

chore!: consolidate test package #1647

merged 1 commit into from
Apr 24, 2023

Conversation

cmwaters
Copy link
Contributor

The large diff is purely from renaming directories and changing import paths. There is no change to the code.

This PR consolidates our testing based packages into a single test package

@MSevey MSevey requested a review from a team April 24, 2023 08:34
@cmwaters cmwaters self-assigned this Apr 24, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1647 (53f2ccf) into main (8c1fcb5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1647   +/-   ##
=======================================
  Coverage   50.96%   50.96%           
=======================================
  Files          92       92           
  Lines        5751     5751           
=======================================
  Hits         2931     2931           
  Misses       2520     2520           
  Partials      300      300           
Impacted Files Coverage Δ
test/tokenfilter/setup.go 100.00% <ø> (ø)
test/txsim/account.go 67.44% <ø> (ø)
test/txsim/blob.go 80.64% <ø> (ø)
test/txsim/client.go 78.88% <ø> (ø)
test/txsim/run.go 61.81% <ø> (ø)
test/txsim/send.go 89.65% <ø> (ø)
test/txsim/stake.go 65.21% <ø> (ø)
test/util/testnode/full_node.go 82.87% <ø> (ø)
test/util/testnode/node_init.go 64.17% <ø> (ø)
test/util/testnode/node_interaction_api.go 58.97% <ø> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for tidying up 🙂

@cmwaters cmwaters merged commit 058442d into main Apr 24, 2023
28 checks passed
@cmwaters cmwaters deleted the cal/test-utils branch April 24, 2023 12:58
rootulp pushed a commit to rootulp/celestia-app that referenced this pull request May 2, 2023
This PR consolidates our testing based packages into a single `test`
package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants