chore: register blob msg server in module #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSevey
requested review from
a team,
rootulp and
mojtaba-esk
and removed request for
a team
evan-forbes
requested review from
cmwaters and
rach-id
and removed request for
mojtaba-esk
Codecov Report
@@ Coverage Diff @@
## main #1653 +/- ##
=======================================
Coverage 50.98% 50.99%
=======================================
Files 92 92
Lines 5749 5748 -1
=======================================
Hits 2931 2931
+ Misses 2519 2518 -1
Partials 299 299
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rach-id
approved these changes
Apr 24, 2023
rootulp
approved these changes
Apr 24, 2023
cmwaters
approved these changes
Apr 25, 2023
The querier was registered. The msg server is just for transactions |
Aaah I see, then how are we sending pay for blob transactions? |
the sdk was using the legacy mechanism, which we're also registering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is pretty standard to do in the sdk, not sure how we haven't done this yet given over two years of running the state machine and audits lol
Everything was still occurring via the legacy sdk.Router, but still...
Checklist