Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: document that MsgPayForBlobs implements LegacyMsg interface #1654

Merged
merged 1 commit into from
Apr 27, 2023
Merged

chore: document that MsgPayForBlobs implements LegacyMsg interface #1654

merged 1 commit into from
Apr 27, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Apr 24, 2023

The Cosmos SDK docs are pretty confusing. They describe two different ways to define a message:

  1. https://docs.cosmos.network/v0.46/building-modules/messages-and-queries.html#msg-services
  2. https://docs.cosmos.network/v0.46/building-modules/messages-and-queries.html#legacy-amino-legacymsgs

MsgPayForBlobs uses option 2. This PR attempts to clarify that.

@rootulp rootulp added this to the Mainnet milestone Apr 24, 2023
@rootulp rootulp self-assigned this Apr 24, 2023
@rootulp rootulp marked this pull request as ready for review April 26, 2023 19:50
@rootulp rootulp requested a review from cmwaters April 26, 2023 19:50
@cmwaters
Copy link
Contributor

I guess this raises the question of whether we want to use the msg server approach?

@rootulp
Copy link
Collaborator Author

rootulp commented Apr 26, 2023

Relevant context:

  1. LegacyMsg in payment module deprecated in favor of Msg Services informalsystems/audit-celestia#1 (comment)
  2. refactor: register msg service #1080 (review)

@rootulp rootulp merged commit 3a9b939 into celestiaorg:main Apr 27, 2023
25 checks passed
@rootulp rootulp deleted the rp/legacy-msg branch April 28, 2023 12:19
@rootulp rootulp mentioned this pull request Apr 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rootulp @cmwaters @evan-forbes