Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to celestia-core v1.18.0-tm-v0.34.27 #1664

Merged
merged 5 commits into from
May 2, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Apr 26, 2023

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Apr 26, 2023
@rootulp rootulp added this to the Mainnet milestone Apr 26, 2023
@rootulp rootulp self-assigned this Apr 26, 2023
@rootulp rootulp requested a review from cmwaters April 26, 2023 19:56
pkg/appconsts/consensus_consts.go Show resolved Hide resolved
testing/e2e/pkg/setup.go Show resolved Hide resolved
@rootulp rootulp marked this pull request as ready for review April 27, 2023 17:45
cmwaters
cmwaters previously approved these changes Apr 28, 2023
pkg/appconsts/consensus_consts.go Show resolved Hide resolved
tmCfg.Consensus.TimeoutCommit = time.Millisecond * 300
// Reduce the target height duration so that blocks are produced faster
// during tests.
tmCfg.Consensus.TargetHeightDuration = time.Millisecond * 300
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that's not going to be too fast. I guess if consensus can't handle it, it won't be that bad

testing/e2e/pkg/setup.go Show resolved Hide resolved
cmwaters
cmwaters previously approved these changes Apr 28, 2023
@rootulp rootulp marked this pull request as ready for review April 28, 2023 21:50
@rootulp rootulp enabled auto-merge (squash) April 28, 2023 21:50
@rootulp rootulp requested a review from cmwaters April 28, 2023 21:50
cmwaters
cmwaters previously approved these changes Apr 29, 2023
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question

x/blob/types/blob_tx.go Outdated Show resolved Hide resolved
@MSevey MSevey requested a review from a team May 1, 2023 03:09
@rootulp rootulp disabled auto-merge May 1, 2023 03:09
@codecov-commenter
Copy link

Codecov Report

Merging #1664 (14d4c73) into main (53e68f3) will decrease coverage by 0.10%.
The diff coverage is 44.77%.

@@            Coverage Diff             @@
##             main    #1664      +/-   ##
==========================================
- Coverage   52.90%   52.80%   -0.10%     
==========================================
  Files          97       97              
  Lines        6206     6259      +53     
==========================================
+ Hits         3283     3305      +22     
- Misses       2594     2620      +26     
- Partials      329      334       +5     
Impacted Files Coverage Δ
app/app.go 4.66% <0.00%> (ø)
test/util/testnode/read.go 0.00% <0.00%> (ø)
x/blob/types/blob_tx.go 14.73% <0.00%> (-2.99%) ⬇️
pkg/square/square.go 67.39% <40.00%> (-4.04%) ⬇️
pkg/square/builder.go 84.21% <57.14%> (-1.79%) ⬇️
pkg/shares/share_sequence.go 75.00% <62.50%> (-2.78%) ⬇️
pkg/shares/parse.go 76.19% <72.72%> (+3.96%) ⬆️
test/util/testnode/full_node.go 83.10% <100.00%> (+0.23%) ⬆️

@rootulp rootulp merged commit db1ccfd into celestiaorg:main May 2, 2023
24 checks passed
rootulp added a commit to rootulp/celestia-app that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants