feat!: Remove support for legacy plain text proposals #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1668 +/- ##
=======================================
Coverage 51.56% 51.57%
=======================================
Files 95 95
Lines 5954 5953 -1
=======================================
Hits 3070 3070
+ Misses 2570 2569 -1
Partials 314 314
|
cmwaters
previously approved these changes
Apr 27, 2023
liamsi
reviewed
Apr 27, 2023
app/test/std_sdk_test.go
Outdated
| expectedCode: abci.CodeTypeOK, | ||
| // plain text proposals have been removed, so we expect an error. "No | ||
| // handler exists for proposal type" | ||
| expectedCode: uint32(9), |
There was a problem hiding this comment.
is there no specific CodeType that can be used instead of uint32(9)?
rach-id
previously approved these changes
Apr 27, 2023
rootulp
reviewed
Apr 27, 2023
There was a problem hiding this comment.
LGTM with one comment. Will approve after you get a chance to view it @evan-forbes so that this doesn't auto-merge
rootulp
approved these changes
Apr 27, 2023
cmwaters
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes legacy text proposals. While it is still possible to submit other proposals that are functionally very similar, here we are being explicit by removing the ability to handle text proposals.
part of #1593
Checklist