Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor variable name from len to length #1675

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

Chirag018
Copy link
Contributor

I have made some changes to the code in this pull request. The main change is that I have renamed the variable len to length. This is because len is a built-in function in Go, and using it as a variable name can cause confusion and potential issues down the line. It is best practice to use a different name, and length is a clear and descriptive alternative.

@MSevey MSevey requested a review from a team April 29, 2023 09:28
@codecov-commenter
Copy link

Codecov Report

Merging #1675 (02b3239) into main (53e68f3) will increase coverage by 0.09%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #1675      +/-   ##
==========================================
+ Coverage   52.90%   52.99%   +0.09%     
==========================================
  Files          97       97              
  Lines        6206     6231      +25     
==========================================
+ Hits         3283     3302      +19     
- Misses       2594     2598       +4     
- Partials      329      331       +2     
Impacted Files Coverage Δ
app/app.go 4.66% <0.00%> (ø)
test/util/testnode/read.go 0.00% <0.00%> (ø)
pkg/shares/share_sequence.go 75.00% <62.50%> (-2.78%) ⬇️
pkg/shares/parse.go 76.19% <72.72%> (+3.96%) ⬆️

@rootulp rootulp enabled auto-merge (squash) April 30, 2023 20:21
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Chirag018 🙂

@rootulp rootulp merged commit a0f1b97 into celestiaorg:main May 1, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants