test: integration test `x/mint` #1791

rootulp · 2023-05-18T22:28:38Z

…e minimum 10 day blocks

evan-forbes

besides testing for the year thing, it's very likely overkill, but we might also want to test that the funds are actually going where we think they are, so querying for the validator account (named "validator" in the keyring) which has some stake already delegated (or creating a new account and staking), and then looking at the module account that holds the community funds

x/mint/test/mint_test.go

x/mint/types/constants.go

x/mint/test/mint_test.go

Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>

Per https://go.dev/doc/effective_go#Getters

--- FAIL: TestIntegrationTestSuite/TestTotalSupplyIncreasesOverTime (1.00s) /Users/rootulp/git/rootulp/celestia/celestia-app/x/mint/test/suite.go:87: test panicked: runtime error: invalid memory address or nil pointer dereference goroutine 2012 [running]: runtime/debug.Stack() /opt/homebrew/Cellar/go/1.20.4/libexec/src/runtime/debug/stack.go:24 +0x64 github.com/stretchr/testify/suite.failOnPanic(0x140047a96c0, {0x104a639a0, 0x105ecebd0}) /Users/rootulp/go/pkg/mod/github.com/stretchr/testify@v1.8.2/suite/suite.go:87 +0x34 github.com/stretchr/testify/suite.Run.func1.1() /Users/rootulp/go/pkg/mod/github.com/stretchr/testify@v1.8.2/suite/suite.go:183 +0x1f4 panic({0x104a639a0, 0x105ecebd0}) /opt/homebrew/Cellar/go/1.20.4/libexec/src/runtime/panic.go:884 +0x204 github.com/celestiaorg/celestia-app/x/mint/test.(*IntegrationTestSuite).GetTotalSupply(0x140001c1900, 0x0?) /Users/rootulp/git/rootulp/celestia/celestia-app/x/mint/test/mint_test.go:106 +0xdc github.com/celestiaorg/celestia-app/x/mint/test.(*IntegrationTestSuite).TestTotalSupplyIncreasesOverTime(0x140001c1900) /Users/rootulp/git/rootulp/celestia/celestia-app/x/mint/test/mint_test.go:62 +0x68 reflect.Value.call({0x14000df8ac0?, 0x14000d2c928?, 0x140044e2d01?}, {0x103e6a8b7, 0x4}, {0x14000db8e68, 0x1, 0x103e393f0?}) /opt/homebrew/Cellar/go/1.20.4/libexec/src/reflect/value.go:586 +0x87c reflect.Value.Call({0x14000df8ac0?, 0x14000d2c928?, 0x140001c1900?}, {0x14000db8e68?, 0x1052e1d48?, 0x3d?}) /opt/homebrew/Cellar/go/1.20.4/libexec/src/reflect/value.go:370 +0x90 github.com/stretchr/testify/suite.Run.func1(0x140047a96c0) /Users/rootulp/go/pkg/mod/github.com/stretchr/testify@v1.8.2/suite/suite.go:197 +0x3f0 testing.tRunner(0x140047a96c0, 0x14004bbed80) /opt/homebrew/Cellar/go/1.20.4/libexec/src/testing/testing.go:1576 +0x10c created by testing.(*T).Run /opt/homebrew/Cellar/go/1.20.4/libexec/src/testing/testing.go:1629 +0x368 /Users/rootulp/git/rootulp/celestia/celestia-app/x/mint/test/full_node.go:226: tearing down testnode

This reverts commit ee4e3b4.

timestamps don't appear to be advancing by 10 days per block: latestTimestamp 2023-05-24 16:25:25.810474 -0400 EDT latestTimestamp 2023-05-24 16:25:27.009179 -0400 EDT latestTimestamp 2023-05-24 16:25:27.906415 -0400 EDT latestTimestamp 2023-05-24 16:25:28.804406 -0400 EDT latestTimestamp 2023-05-24 16:25:29.713275 -0400 EDT latestTimestamp 2023-05-24 16:25:30.910224 -0400 EDT latestTimestamp 2023-05-24 16:25:31.804267 -0400 EDT latestTimestamp 2023-05-24 16:25:33.028104 -0400 EDT latestTimestamp 2023-05-24 16:25:33.917395 -0400 EDT latestTimestamp 2023-05-24 16:25:34.807346 -0400 EDT latestTimestamp 2023-05-24 16:25:36.011127 -0400 EDT latestTimestamp 2023-05-24 16:25:36.910078 -0400 EDT latestTimestamp 2023-05-24 16:25:37.805972 -0400 EDT latestTimestamp 2023-05-24 16:25:39.009305 -0400 EDT latestTimestamp 2023-05-24 16:25:39.907823 -0400 EDT latestTimestamp 2023-05-24 16:25:40.811224 -0400 EDT latestTimestamp 2023-05-24 16:25:42.007382 -0400 EDT latestTimestamp 2023-05-24 16:25:42.913254 -0400 EDT latestTimestamp 2023-05-24 16:25:43.806334 -0400 EDT latestTimestamp 2023-05-24 16:25:44.708312 -0400 EDT

codecov-commenter · 2023-05-24T20:41:03Z

Codecov Report

Merging #1791 (1452079) into main (db15dcb) will decrease coverage by 0.03%.
The diff coverage is 19.67%.

@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
- Coverage   21.82%   21.80%   -0.03%     
==========================================
  Files         116      117       +1     
  Lines       13247    13306      +59     
==========================================
+ Hits         2891     2901      +10     
- Misses      10065    10114      +49     
  Partials      291      291

Impacted Files	Coverage Δ
test/util/testnode/node_interaction_api.go	`0.00% <0.00%> (ø)`
x/mint/types/constants.go	`100.00% <100.00%> (ø)`
x/mint/types/minter.go	`71.11% <100.00%> (+2.81%)`	⬆️

initial supply: 100000001145805461utia initial timestamp: 100000001145805461utia wantAsFloat: 8 latestTimestamp 2023-05-27 22:51:42.033432 +0000 UTC later supply: 100000001449542529utia later timestamp: 2023-05-27 22:51:42.033432 +0000 UTC wantAsFloat: 7.2 latestTimestamp 2023-05-27 22:51:42.935906 +0000 UTC latestTimestamp 2023-05-27 22:51:43.838663 +0000 UTC latestTimestamp 2023-05-27 22:51:45.03145 +0000 UTC latestTimestamp 2023-05-27 22:51:45.93342 +0000 UTC latestTimestamp 2023-05-27 22:51:46.835305 +0000 UTC latestTimestamp 2023-05-27 22:51:48.037924 +0000 UTC latestTimestamp 2023-05-27 22:51:48.934952 +0000 UTC latestTimestamp 2023-05-27 22:51:49.837673 +0000 UTC latestTimestamp 2023-05-27 22:51:51.03862 +0000 UTC latestTimestamp 2023-05-27 22:51:51.934761 +0000 UTC latestTimestamp 2023-05-27 22:51:52.832512 +0000 UTC latestTimestamp 2023-05-27 22:51:54.041073 +0000 UTC latestTimestamp 2023-05-27 22:51:54.938937 +0000 UTC latestTimestamp 2023-05-27 22:51:55.834115 +0000 UTC latestTimestamp 2023-05-27 22:51:57.036927 +0000 UTC latestTimestamp 2023-05-27 22:51:57.937073 +0000 UTC latestTimestamp 2023-05-27 22:51:58.837436 +0000 UTC latestTimestamp 2023-05-27 22:52:00.044855 +0000 UTC latestTimestamp 2023-05-27 22:52:00.93712 +0000 UTC latestTimestamp 2023-05-27 22:52:01.841579 +0000 UTC

wantAsFloat: 8 inflationRate 0.081714102022966438 startTimestamp 2024-05-28 09:08:16.58339 +0000 UTC, endTimestamp: 2025-05-28 14:57:28.58339 +0000 UTC startHeight: 38, endHeight: 75 wantAsFloat: 7.2 inflationRate 0.075374835778984813

cmwaters

LGTM. Few comments, but nothing blocking

x/mint/test/mint_test.go

evan-forbes

nice, no blocking comments or really that much more than the initial review!

x/mint/test/mint_test.go

Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>

evan-forbes

apruuve 👍

rootulp added 5 commits May 18, 2023 17:27

test: total supply increases over time

3a27a42

wip: TestInitialInflationRate

61abf0d

feat: export decimal inflration rates

313fe0b

test: TestInitialInflationRate

77327b1

test: remove debug logs

4baa511

rootulp added the testing items that are strictly related to adding or extending test coverage label May 18, 2023

rootulp added this to the Mainnet milestone May 18, 2023

rootulp self-assigned this May 18, 2023

refactor: change to NewNetwork and change the consensus params to hav…

736bea7

…e minimum 10 day blocks

evan-forbes reviewed May 19, 2023

View reviewed changes

rootulp and others added 2 commits May 22, 2023 12:58

Update x/mint/test/mint_test.go

97e8d31

Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>

getters for inflation rates as decimal

fcfbf4b

rootulp mentioned this pull request May 22, 2023

Un-export namespace slices and export getters #1809

Closed

rootulp added 10 commits May 22, 2023 13:09

remove Get prefix

7173dc6

Per https://go.dev/doc/effective_go#Getters

implement GetTotalSupplyAndTimestamp

5dd630f

refactor: GetTotalSupplyAndTimestamp

5b4fdca

refactor: remove ParseDuration for one year

61cb60f

remove: LatestBlockTime

3180c35

docs: improve TimeIotaMs comment

84445e9

Merge branch 'main' into rp/test-inflation

3b59fd7

Revert "wip: attempt to use GRPC client"

be97cfd

This reverts commit ee4e3b4.

rootulp added 6 commits May 27, 2023 18:54

fix: TimeIotaMs hack

26e6c3f

wip: TestInflationRate

6f887a8

convert comment to test cases

efcef09

wip: pretty close to expected inflation rate

792d71b

wantAsFloat: 8 inflationRate 0.081714102022966438 startTimestamp 2024-05-28 09:08:16.58339 +0000 UTC, endTimestamp: 2025-05-28 14:57:28.58339 +0000 UTC startHeight: 38, endHeight: 75 wantAsFloat: 7.2 inflationRate 0.075374835778984813

test passes for first five years

be871ed

fix: lint

4f56500

rootulp requested a review from evan-forbes May 29, 2023 04:19

rootulp marked this pull request as ready for review May 29, 2023 04:22

rootulp requested a review from cmwaters as a code owner May 29, 2023 04:22

cmwaters previously approved these changes May 30, 2023

View reviewed changes

x/mint/test/mint_test.go Outdated Show resolved Hide resolved

x/mint/test/mint_test.go Outdated Show resolved Hide resolved

note: technique stops working w/ removal of TimeIotaMs

9cfd867

rootulp dismissed cmwaters’s stale review via 9cfd867 May 30, 2023 17:09

MSevey requested a review from a team May 30, 2023 17:09

refactor: use proto.Unmarshal

8e448ef

rootulp requested a review from cmwaters May 30, 2023 17:14

evan-forbes reviewed May 30, 2023

View reviewed changes

x/mint/test/mint_test.go Outdated Show resolved Hide resolved

x/mint/test/mint_test.go Outdated Show resolved Hide resolved

x/mint/test/mint_test.go Show resolved Hide resolved

evan-forbes previously approved these changes May 30, 2023

View reviewed changes

Update x/mint/test/mint_test.go

d808673

Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>

rootulp dismissed evan-forbes’s stale review via d808673 May 30, 2023 21:23

MSevey requested a review from a team May 30, 2023 21:24

rootulp added 2 commits May 30, 2023 17:28

move skip to TestIntegrationTestSuite

078fd22

fix import

a453cf1

evan-forbes previously approved these changes May 30, 2023

View reviewed changes

bump to six months

9c6d95c

rootulp dismissed evan-forbes’s stale review via 9c6d95c May 30, 2023 21:33

MSevey requested a review from a team May 30, 2023 21:34

evan-forbes approved these changes May 30, 2023

View reviewed changes

Merge branch 'main' into rp/test-inflation

1452079

MSevey requested a review from a team May 31, 2023 18:25

evan-forbes requested review from rach-id and removed request for a team May 31, 2023 18:25

rootulp enabled auto-merge (squash) May 31, 2023 20:03

rach-id approved these changes May 31, 2023

View reviewed changes

rootulp merged commit 9780f96 into celestiaorg:main May 31, 2023
15 checks passed

rootulp deleted the rp/test-inflation branch June 1, 2023 14:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: integration test `x/mint` #1791

test: integration test `x/mint` #1791

rootulp commented May 18, 2023

evan-forbes left a comment

codecov-commenter commented May 24, 2023 •

edited

cmwaters left a comment

evan-forbes left a comment

evan-forbes left a comment

test: integration test x/mint #1791

test: integration test x/mint #1791

Conversation

rootulp commented May 18, 2023

evan-forbes left a comment

Choose a reason for hiding this comment

codecov-commenter commented May 24, 2023 • edited

Codecov Report

cmwaters left a comment

Choose a reason for hiding this comment

evan-forbes left a comment

Choose a reason for hiding this comment

evan-forbes left a comment

Choose a reason for hiding this comment

test: integration test `x/mint` #1791

test: integration test `x/mint` #1791

codecov-commenter commented May 24, 2023 •

edited