-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests for validSequenceLen
#1817
Merged
rootulp
merged 4 commits into
celestiaorg:main
from
rootulp:rp/test-valid-sequence-length
May 26, 2023
Merged
test: add tests for validSequenceLen
#1817
rootulp
merged 4 commits into
celestiaorg:main
from
rootulp:rp/test-valid-sequence-length
May 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
added
the
testing
items that are strictly related to adding or extending test coverage
label
May 23, 2023
Codecov Report
@@ Coverage Diff @@
## main #1817 +/- ##
==========================================
+ Coverage 21.84% 21.87% +0.03%
==========================================
Files 116 116
Lines 13232 13232
==========================================
+ Hits 2890 2894 +4
+ Misses 10050 10047 -3
+ Partials 292 291 -1 |
rootulp
changed the title
test: Test_validSequenceLen
test: add tests for May 24, 2023
validSequenceLen
cmwaters
approved these changes
May 25, 2023
evan-forbes
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of investigating #1816
Note: an implementation change isn't necessary b/c the bug was already fixed by #1662