Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for validSequenceLen #1817

Merged
merged 4 commits into from
May 26, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented May 23, 2023

Part of investigating #1816

Note: an implementation change isn't necessary b/c the bug was already fixed by #1662

@rootulp rootulp added the testing items that are strictly related to adding or extending test coverage label May 23, 2023
@rootulp rootulp self-assigned this May 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Merging #1817 (ebd9b73) into main (a9a0d36) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1817      +/-   ##
==========================================
+ Coverage   21.84%   21.87%   +0.03%     
==========================================
  Files         116      116              
  Lines       13232    13232              
==========================================
+ Hits         2890     2894       +4     
+ Misses      10050    10047       -3     
+ Partials      292      291       -1     

see 1 file with indirect coverage changes

@rootulp rootulp marked this pull request as ready for review May 24, 2023 17:00
@rootulp rootulp changed the title test: Test_validSequenceLen test: add tests for validSequenceLen May 24, 2023
@rootulp rootulp enabled auto-merge (squash) May 25, 2023 13:51
@MSevey MSevey requested a review from a team May 26, 2023 11:49
@rootulp rootulp merged commit 7e93692 into celestiaorg:main May 26, 2023
15 checks passed
evan-forbes pushed a commit that referenced this pull request May 26, 2023
Part of investigating
#1816

Note: an implementation change isn't necessary b/c the bug was already
fixed by #1662
evan-forbes pushed a commit that referenced this pull request May 26, 2023
Part of investigating
#1816

Note: an implementation change isn't necessary b/c the bug was already
fixed by #1662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants