chore: adds _flaky suffix to flaky tests #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1833 +/- ##
=======================================
Coverage 21.82% 21.82%
=======================================
Files 116 116
Lines 13247 13247
=======================================
Hits 2891 2891
Misses 10065 10065
Partials 291 291 |
rootulp
approved these changes
May 25, 2023
|
@evan-forbes Can we confirm whether we have reached an agreement regarding the changes in this PR? If not, do we prefer to retain the current test names as they are? please let me know your decision! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As per our call, this PR adds a _flaky suffix to flaky tests identified so far.
Checklist