Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the valset normalization docs #1846

Merged
merged 5 commits into from
Jun 12, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented May 26, 2023

Overview

Closes #1815

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added documentation Improvements or additions to documentation x/qgb labels May 26, 2023
@rach-id rach-id self-assigned this May 26, 2023
@rach-id rach-id requested a review from evan-forbes as a code owner May 26, 2023 22:33
@MSevey MSevey requested review from a team and staheri14 and removed request for a team May 26, 2023 22:33
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Merging #1846 (f4f497f) into main (bdbdeb0) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1846      +/-   ##
==========================================
- Coverage   21.22%   21.21%   -0.02%     
==========================================
  Files         120      120              
  Lines       13696    13694       -2     
==========================================
- Hits         2907     2905       -2     
  Misses      10499    10499              
  Partials      290      290              
Impacted Files Coverage Δ
x/qgb/keeper/keeper_valset.go 34.42% <ø> (-1.06%) ⬇️
x/qgb/types/validator.go 39.79% <ø> (ø)

evan-forbes
evan-forbes previously approved these changes May 29, 2023
x/qgb/types/validator.go Show resolved Hide resolved
rootulp
rootulp previously approved these changes May 29, 2023
staheri14
staheri14 previously approved these changes May 29, 2023
Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! included some questions.

x/qgb/keeper/keeper_valset.go Outdated Show resolved Hide resolved
x/qgb/keeper/keeper_valset.go Show resolved Hide resolved
x/qgb/types/validator.go Outdated Show resolved Hide resolved
@rach-id rach-id dismissed stale reviews from staheri14, rootulp, and evan-forbes via 3e73d1c May 31, 2023 09:28
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
@MSevey MSevey requested a review from a team May 31, 2023 09:29
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
evan-forbes
evan-forbes previously approved these changes May 31, 2023
cmwaters
cmwaters previously approved these changes Jun 9, 2023
x/qgb/keeper/keeper_valset.go Show resolved Hide resolved
@rach-id rach-id dismissed stale reviews from cmwaters and evan-forbes via bf7af2d June 9, 2023 15:11
@MSevey MSevey requested a review from a team June 9, 2023 15:12
@MSevey MSevey requested a review from a team June 12, 2023 13:50
@rach-id rach-id merged commit 6243f26 into celestiaorg:main Jun 12, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate the valset creation normalization
6 participants