-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update the valset normalization docs #1846
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1846 +/- ##
==========================================
- Coverage 21.22% 21.21% -0.02%
==========================================
Files 120 120
Lines 13696 13694 -2
==========================================
- Hits 2907 2905 -2
Misses 10499 10499
Partials 290 290
|
evan-forbes
previously approved these changes
May 29, 2023
rootulp
previously approved these changes
May 29, 2023
staheri14
previously approved these changes
May 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! included some questions.
cmwaters
reviewed
May 30, 2023
rach-id
dismissed stale reviews from staheri14, rootulp, and evan-forbes
via
May 31, 2023 09:28
3e73d1c
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
evan-forbes
previously approved these changes
May 31, 2023
cmwaters
previously approved these changes
Jun 9, 2023
cmwaters
approved these changes
Jun 12, 2023
evan-forbes
approved these changes
Jun 12, 2023
staheri14
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #1815
Checklist