Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: rename to ValidateBlobNamespace #1850

Merged
merged 2 commits into from
May 31, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented May 29, 2023

Closes #1849

@rootulp rootulp added the warn:api breaking item will be break an API and require a major bump label May 29, 2023
@rootulp rootulp requested a review from evan-forbes as a code owner May 29, 2023 15:42
@rootulp rootulp self-assigned this May 29, 2023
@rootulp rootulp requested a review from cmwaters as a code owner May 29, 2023 15:42
@MSevey MSevey requested a review from a team May 29, 2023 15:42
@codecov-commenter
Copy link

Codecov Report

Merging #1850 (06de611) into main (1e60076) will decrease coverage by 29.72%.
The diff coverage is 11.15%.

@@             Coverage Diff             @@
##             main    #1850       +/-   ##
===========================================
- Coverage   51.54%   21.82%   -29.72%     
===========================================
  Files          95      116       +21     
  Lines        6220    13247     +7027     
===========================================
- Hits         3206     2891      -315     
- Misses       2671    10065     +7394     
+ Partials      343      291       -52     
Impacted Files Coverage Δ
app/app.go 4.48% <0.00%> (-0.05%) ⬇️
app/default_overrides.go 23.37% <0.00%> (ø)
app/prepare_proposal.go 0.00% <0.00%> (ø)
app/process_proposal.go 0.00% <0.00%> (ø)
app/square_size.go 0.00% <0.00%> (ø)
pkg/proof/querier.go 21.50% <ø> (ø)
test/util/testnode/full_node.go 0.00% <0.00%> (-83.88%) ⬇️
test/util/testnode/genesis_options.go 0.00% <0.00%> (ø)
test/util/testnode/node_interaction_api.go 0.00% <0.00%> (-57.53%) ⬇️
x/blob/types/params.pb.go 1.27% <0.00%> (ø)
... and 24 more

... and 37 files with indirect coverage changes

@evan-forbes evan-forbes enabled auto-merge (squash) May 31, 2023 14:49
@MSevey MSevey requested a review from a team May 31, 2023 14:49
@evan-forbes evan-forbes merged commit 7c96e74 into celestiaorg:main May 31, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
warn:api breaking item will be break an API and require a major bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove trailing ID from ValidateBlobNamespaceID
4 participants