Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update common docker ci pipeline #1886

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

Bidon15
Copy link
Member

@Bidon15 Bidon15 commented Jun 6, 2023

Overview

We have the same building bumps for node celestiaorg/celestia-node#2330
QGB orchestrator already contains the latest version of the common docker build pipeline

https://github.com/celestiaorg/orchestrator-relayer/blob/main/.github/workflows/docker-build-publish.yml

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Bidon15 Bidon15 requested a review from rach-id June 6, 2023 12:36
@Bidon15 Bidon15 self-assigned this Jun 6, 2023
@MSevey MSevey requested a review from a team June 6, 2023 12:36
@Bidon15 Bidon15 added github_actions chore optional label for items that follow the `chore` conventional commit CI item that directly relates to or modify the CI and removed external labels Jun 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1886 (36f6ce2) into main (6a57fcd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1886   +/-   ##
=======================================
  Coverage   21.85%   21.85%           
=======================================
  Files         117      117           
  Lines       13304    13304           
=======================================
  Hits         2907     2907           
  Misses      10107    10107           
  Partials      290      290           

@rootulp
Copy link
Collaborator

rootulp commented Jun 6, 2023

@evan-forbes
Copy link
Member

evan-forbes commented Jun 6, 2023

@Bidon15 what do you think we should do about the failing the docker-build? is this to be expected?

#14 DONE 0.0s

#15 exporting to image
#15 exporting layers
#15 exporting layers 3.9s done
#15 exporting manifest sha256:bb3ae26af8031199de3da85d2a6c08a116c2c15dc6218d229d6a8b17b8988632 done
#15 exporting config sha256:8df457b7fb00b7a3c9e7f963d5ecf9c98d0279d9adb95b50e04f7381d172d04b done
#15 exporting attestation manifest sha256:4f59b7df7eb3ff78162ae128d0a246848f1fdf2424aa53b587a03129c2db461d done
#15 exporting manifest list sha256:8ec47048157d1280e682648ab424d0a261adde57992953326659ce8d0bb7b161 done
#15 pushing layers
#15 ...

#16 [auth] celestiaorg/celestia-app:pull,push token for ghcr.io
#16 DONE 0.0s

#15 exporting to image
#15 pushing layers 0.5s done
#15 ERROR: failed to push ghcr.io/celestiaorg/celestia-app:pr-1886: unexpected status: 403 Forbidden
------
 > exporting to image:
------
ERROR: failed to solve: failed to push ghcr.io/celestiaorg/celestia-app:pr-1886: unexpected status: 403 Forbidden
Error: buildx failed with: ERROR: failed to solve: failed to push ghcr.io/celestiaorg/celestia-app:pr-1886: unexpected status: 403 Forbidden

@rach-id
Copy link
Member

rach-id commented Jun 6, 2023

Could the failing CI be because of write access for @Bidon15 ?
I did the same change in orchestrator-relayer, and it's not failing even if I'm opening PRs from a fork

@evan-forbes
Copy link
Member

that would make sense, we can merge and revert if necessary

@evan-forbes evan-forbes merged commit af3253c into celestiaorg:main Jun 7, 2023
15 of 16 checks passed
@rach-id
Copy link
Member

rach-id commented Jun 7, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit CI item that directly relates to or modify the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants