chore!: bump sdk and core #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
previously approved these changes
Jun 12, 2023
rach-id
reviewed
Jun 12, 2023
rootulp
previously approved these changes
Jun 13, 2023
app/square_size.go
Outdated
| @@ -14,7 +14,7 @@ func (app *App) GovSquareSizeUpperBound(ctx sdk.Context) int { | |||
| // of the sdk and comet that have full support of PreparePropsoal, although | |||
| // celestia-app does not currently use those. see this PR for more | |||
| // details https://github.com/cosmos/cosmos-sdk/pull/14505 | |||
There was a problem hiding this comment.
is this comment still accurate? Specifically the "are not >= 1." part?
cmwaters
approved these changes
Jun 13, 2023
| // BeginBlock of the first block. This is remedied in versions of the sdk | ||
| // and comet that have full support of PreparePropsoal, although | ||
| // celestia-app does not currently use those. see this PR for more details | ||
| // https://github.com/cosmos/cosmos-sdk/pull/14505 |
There was a problem hiding this comment.
Are we going to port this across?
Codecov Report
@@ Coverage Diff @@
## main #1912 +/- ##
=======================================
Coverage 21.21% 21.21%
=======================================
Files 120 120
Lines 13694 13694
=======================================
Hits 2905 2905
Misses 10499 10499
Partials 290 290
|
rootulp
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
bumps to our forks of the cosmos-sdk and comet to their latest versions. This is consensus breaking because an event was modified in the sdk, although that event may or may not have gotten hit on mocha-2 already.
blocked by celestiaorg/cosmos-sdk#326, celestiaorg/cosmos-sdk#324, celestiaorg/celestia-core#1021