feat!: remove genesis time from genesis state (#1851) #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes celestiaorg#1757 Prior to this PR, the mint module contained a placeholder `genesis_time` in genesis state. It ignored the placeholder and used the block time for the block height `1` as the "genesis time". This PR removes the placeholder and that mechanism. ```diff "minter": { "inflation_rate": "0.080000000000000000", "annual_provisions": "0.000000000000000000", - "genesis_time": "2023-06-22T18:46:11.873883Z", "previous_block_time": null, "bond_denom": "utia" } ``` After this PR, `genesis_time` in the mint module is set to the chain's genesis time which is the root level `genesis_time` specified in genesis.json. Genesis.json is created on chain initialization (i.e. `celestia-appd init chain-id`). This is breaking b/c it modifies a state transition for the mint module state and removes a field from the `Minter` state. Now there is only one `genesis_time` in genesis.json: ```shell $ ./scripts/build-run-single-node.sh $ cat /var/folders/y0/dd92_x8x4tlf397xstgwfz_c0000gn/T/celestia_app_XXXXXXXXXXXXX.wYBu5mwm/config/genesis.json | grep genesis_time -A 3 -B 3 { "genesis_time": "2023-06-23T16:13:24.719488Z", "chain_id": "private", "initial_height": "1", "consensus_params": { ``` Additionally it gets set correctly in mint module state ```shell $ ./build/celestia-appd query mint genesis-time 2023-06-23 16:13:24.719488 +0000 UTC ``` --------- Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
rootulp
added
the
consensus breaking
evan-forbes
previously approved these changes
Jun 23, 2023
|
looks like the proto has to be regenerated
|
rach-id
approved these changes
Jun 23, 2023
evan-forbes
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #1851 to the v1.x release branch