Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable stylecheck #2005

Merged
merged 1 commit into from
Jul 3, 2023
Merged

chore: enable stylecheck #2005

merged 1 commit into from
Jul 3, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jun 29, 2023

Closes #1989

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Jun 29, 2023
@rootulp rootulp self-assigned this Jun 29, 2023
@MSevey MSevey requested a review from a team June 29, 2023 20:24
@codecov-commenter
Copy link

Codecov Report

Merging #2005 (cc3652c) into main (3aa3c09) will not change coverage.
The diff coverage is 35.00%.

@@           Coverage Diff           @@
##             main    #2005   +/-   ##
=======================================
  Coverage   22.08%   22.08%           
=======================================
  Files         130      130           
  Lines       14479    14479           
=======================================
  Hits         3198     3198           
  Misses      10981    10981           
  Partials      300      300
Impacted Files Coverage Δ
app/validate_txs.go 0.00% <0.00%> (ø)
test/util/testnode/config.go 0.00% <0.00%> (ø)
test/util/testnode/node_interaction_api.go 0.00% <0.00%> (ø)
x/blob/types/builder.go 39.67% <0.00%> (ø)
x/qgb/client/query.go 0.00% <0.00%> (ø)
x/qgb/types/genesis.go 78.57% <ø> (ø)
test/util/blobfactory/payforblob_factory.go 18.50% <20.00%> (ø)
x/mint/keeper/genesis.go 75.00% <60.00%> (ø)
test/util/blobfactory/test_util.go 72.72% <100.00%> (ø)
x/blob/types/payforblob.go 72.90% <100.00%> (ø)

cmwaters
cmwaters approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pkg/square/builder_test.go
"github.com/tendermint/tendermint/types"
core "github.com/tendermint/tendermint/types"
coretypes "github.com/tendermint/tendermint/types"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol 3 times

@rootulp rootulp enabled auto-merge (squash) June 30, 2023 19:14
@rootulp rootulp merged commit 83f91ca into celestiaorg:main Jul 3, 2023
17 of 18 checks passed
@rootulp rootulp deleted the rp/enable-stylelint branch July 3, 2023 13:15
evan-forbes pushed a commit that referenced this pull request Jul 3, 2023
@rootulp @evan-forbes
chore: enable stylecheck (#2005)
48a5224 
Closes #1989
evan-forbes pushed a commit that referenced this pull request Jul 3, 2023
@rootulp @evan-forbes
chore: enable stylecheck (#2005)
6218584 
Closes #1989
@rootulp rootulp mentioned this pull request Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

@rach-id rach-id rach-id approved these changes

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

Assignees

@rootulp rootulp

Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable linter to catch when godoc doesn't match function name
4 participants
@rootulp @codecov-commenter @cmwaters @rach-id