chore!: revert testnode changes for rc8 #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
approved these changes
Jul 6, 2023
Wondertan
approved these changes
Jul 6, 2023
rootulp
approved these changes
Jul 6, 2023
evan-forbes
added a commit
that referenced
this pull request
Jul 26, 2023
This reverts commit 71908e5.
evan-forbes
added a commit
that referenced
this pull request
Aug 2, 2023
This reverts commit 71908e5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
this is a strictly api breaking change that will allow us to unblock the celestia-node update. It reverts the two PRs that include changes to testnode. We want those changes long term, but they break the celestia-node tests, which is blocking us merging the bump.
cc @renaynay @Wondertan we will cut rc8 after this
Checklist