Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change default of the tx indexer back to "kv" #2039

Merged
merged 3 commits into from
Jul 6, 2023
Merged

chore: change default of the tx indexer back to "kv" #2039

merged 3 commits into from
Jul 6, 2023

Conversation

evan-forbes
Copy link
Member

Overview

changes the default of the tx indexer back to kv per requested syncronously.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@evan-forbes evan-forbes self-assigned this Jul 6, 2023
@MSevey MSevey requested a review from a team July 6, 2023 12:27
rach-id
rach-id previously approved these changes Jul 6, 2023
View reviewed changes
rootulp
rootulp previously approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by running this locally and observing that config.toml now has:

indexer = "kv"

cmd/celestia-appd/cmd/root.go Outdated Show resolved Hide resolved
@evan-forbes evan-forbes dismissed stale reviews from rootulp and rach-id via 7925ba2 July 6, 2023 16:57
@MSevey MSevey requested a review from a team July 6, 2023 16:57
@evan-forbes evan-forbes enabled auto-merge (squash) July 6, 2023 16:57
@evan-forbes evan-forbes merged commit 4bbcbcb into v1.x Jul 6, 2023
20 checks passed
@evan-forbes evan-forbes deleted the evan/revert-kv-default branch July 6, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp approved these changes

@rach-id rach-id rach-id approved these changes

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

@liamsi liamsi Awaiting requested review from liamsi

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@evan-forbes evan-forbes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evan-forbes @rootulp @rach-id