chore!: cherry pick revert dynamic commits #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumps core and the sdk to revert the timeout commit change. leaving as a draft until the releases of the other repos are created - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
evan-forbes
changed the title
Codecov Report
@@ Coverage Diff @@
## v1.x #2081 +/- ##
=======================================
Coverage ? 21.57%
=======================================
Files ? 126
Lines ? 14271
Branches ? 0
=======================================
Hits ? 3079
Misses ? 10895
Partials ? 297 |
## Overview removes consensus config overrides in the cli ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
Closes #2060 Marked as breaking b/c after this PR `NewDataAvailabilityHeader` may return an error.
rach-id
approved these changes
Jul 11, 2023
staheri14
approved these changes
Jul 11, 2023
5 tasks
rootulp
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR should not be squashed ideally, inclues #2078, #2079, and #2062
we can cut v1.0.0-rc9 after merging this
Checklist