Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backport features to allow node to handle gas price estimation #2134

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

cmwaters
Copy link
Contributor

Backports #2122

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #2134 (b6f2d97) into v1.x (ebfc416) will increase coverage by 0.05%.
The diff coverage is 52.72%.

@@            Coverage Diff             @@
##             v1.x    #2134      +/-   ##
==========================================
+ Coverage   21.57%   21.62%   +0.05%     
==========================================
  Files         126      127       +1     
  Lines       14271    14314      +43     
==========================================
+ Hits         3079     3096      +17     
- Misses      10895    10918      +23     
- Partials      297      300       +3     
Impacted Files Coverage Δ
app/app.go 4.46% <0.00%> (-0.06%) ⬇️
x/blob/types/payforblob.go 68.83% <0.00%> (-4.07%) ⬇️
app/errors/errors.go 75.00% <75.00%> (ø)
x/blob/ante/ante.go 85.00% <100.00%> (-3.47%) ⬇️
x/blob/keeper/keeper.go 80.00% <100.00%> (-2.76%) ⬇️

rootulp
rootulp previously approved these changes Jul 19, 2023
cmwaters and others added 2 commits July 24, 2023 09:56
This also simplifies some of the gas consumption logic between the ante
handler and blob keeper

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
This PR adds logic for handling errors returned in `CheckTx` due to
falling below the min gas price of the node

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
@cmwaters cmwaters marked this pull request as ready for review July 24, 2023 07:57
@rootulp rootulp merged commit 7807722 into v1.x Jul 24, 2023
21 checks passed
@rootulp rootulp deleted the cal/backport-gas-price branch July 24, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants