fix: int overflow for 32 bit machines #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
approved these changes
Jul 19, 2023
evan-forbes
approved these changes
Jul 20, 2023
rootulp
added a commit
to rootulp/celestia-app
that referenced
this pull request
Jul 20, 2023
Closes celestiaorg#2129 celestiaorg#2121 didn't actually fix the issue because the expression ```go NanosecondsPerYear = int64(NanosecondsPerSecond * SecondsPerYear) ``` was multiplying two `int`s together prior to the cast to `int64`. Since the product of those two `int`s overflows an `int32`, the value would overflow prior to the cast. The fix proposed in this PR converts SecondsPerYear to an `int64`. Now the expression multiplies an `int` and `int64` so the product is an `int64` which won't overflow. ## Testing I added this to the Makefile ```go ## build-arm: Build the celestia-appd binary into the ./build directory. Target the linux OS and ARM (32-bit) architecture. build-arm: mod @cd ./cmd/celestia-appd @mkdir -p build/ @Goos=linux GOARCH=arm go build $(BUILD_FLAGS) -o build/ ./cmd/celestia-appd @go mod tidy -compat=1.20 .PHONY: build-arm ``` Before ```shell $ make build-arm --> Updating go.mod # github.com/celestiaorg/celestia-app/x/mint/types x/mint/types/constants.go:15:29: NanosecondsPerSecond * SecondsPerYear (constant 31556952000000000 of type int) overflows int make: *** [build-arm] Error 1 ``` After ```shell $ make build-arm --> Updating go.mod ```
|
Nick is running into this error on an android, I'd imagine maybe the |
|
You're right the celestia-node Makefile doesn't have a If celestia-node, I think we should open an issue in celestia-node repo. |
|
Circling back on this for visibility @jcstein:
If ya'll still observe this error on celestia-node releases that should work, can you please open a new GH issue? |
|
hey @rootulp thanks for following up here. i don’t think an issue is needed, and will see if one of the newer versions works! |
|
assuming it doesn’t happen on a release where it is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2129
#2121 didn't actually fix the issue because the expression
was multiplying two
ints together prior to the cast toint64. Since the product of those twoints overflows anint32, the value would overflow prior to the cast.The fix proposed in this PR converts SecondsPerYear to an
int64. Now the expression multiplies anintandint64so the product is anint64which won't overflow.Testing
I added this to the Makefile
Before
After
$ make build-arm --> Updating go.mod