Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds valset confirm logic and queries #215

Merged
merged 6 commits into from
Feb 18, 2022
Merged

adds valset confirm logic and queries #215

merged 6 commits into from
Feb 18, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Feb 16, 2022 •
edited

Adds logic for ValSetConfirm without tests + asks some questions.
Contributes to #197

@rach-id rach-id marked this pull request as draft February 16, 2022 23:06
@rach-id rach-id marked this pull request as ready for review February 18, 2022 00:21
@rach-id
Copy link
Member Author

rach-id commented Feb 18, 2022

@evan-forbes Please take a look when you have time.
PS: I included some questions there next to FIXMEs. However, the TODOs, I will address them in upcoming PRs.

evan-forbes
evan-forbes approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, I left two comments that I think are important enough that we should write quick issues that point to them and include a small amount of context so that we don't forget to implement/research them later.

pre-approving tho 👍 :shipit:

proto/qgb/query.proto Show resolved Hide resolved
proto/qgb/query.proto Show resolved Hide resolved
x/qgb/client/cli/valsetconfirm.go Outdated Show resolved Hide resolved
x/qgb/client/rest/tx.go Outdated Show resolved Hide resolved
x/qgb/keeper/keeper.go Outdated Show resolved Hide resolved
x/qgb/keeper/keeper.go Outdated Show resolved Hide resolved
x/qgb/keeper/query_valset_confirm_test.go Show resolved Hide resolved
x/qgb/types/keys.go Show resolved Hide resolved
@rach-id
Copy link
Member Author

rach-id commented Feb 18, 2022

@evan-forbes comments addressed. Please merge if everything is in order.

@evan-forbes evan-forbes merged commit 59176d3 into celestiaorg:qgb-integration Feb 18, 2022
@evan-forbes evan-forbes mentioned this pull request Feb 20, 2022
Closed
rach-id added a commit to rach-id/celestia-app that referenced this pull request May 9, 2022
@rach-id
adds valset confirm logic and queries (celestiaorg#215)
cbab2f8 
* adds valset confirm logic and queries

* adds valset confirm logic

* removes unnecessary parameter from qgb keeper

* removes unnecessary cli for valset confirm

* updates comments and removes unnecessary ones

* remove query command from module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rach-id @evan-forbes