chore: backport version string to fallback to the sha256 commit #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hello team!
This is a small PR, it contains a change to print the commit sha when we
are not running an RC or a version, This might be useful when we want to
run specific commits, branches, etc... *Otherwise the value will be
empty.*
This comes from after testing the new metric `version`, I can see this
when we are not running tags:
```
cometbft_consensus_step_duration_seconds_bucket{chain_id="<whatever>"",step="Commit",version="",le="0.2682695795279726"} 153
```
Please team, if you approve it, merge it after, I don't have permission
to do it.
Thanks in advance! 🚀
Jose Ramon Mañes
---------
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Codecov Report
@@ Coverage Diff @@
## v1.x #2218 +/- ##
=======================================
Coverage 21.52% 21.52%
=======================================
Files 128 128
Lines 14383 14383
=======================================
Hits 3096 3096
Misses 10987 10987
Partials 300 300 |
evan-forbes
approved these changes
Aug 7, 2023
rach-id
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports: #2190
Checklist