Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump core to v1.26.2-tm-v0.34.28 (#2272) #2312

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Aug 18, 2023

Overview

cherry pick the core bump commit

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

(cherry picked from commit 3e9ce1f)

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

Closes celestiaorg#2249

Replaces celestiaorg#2263 so that
the workflows do not run for a fork branch and fail

## Checklist

<!--
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

(cherry picked from commit 3e9ce1f)
@rach-id rach-id added dependencies Pull requests that update a dependency file chore optional label for items that follow the `chore` conventional commit labels Aug 18, 2023
@rach-id rach-id self-assigned this Aug 18, 2023
@MSevey MSevey requested a review from a team August 18, 2023 08:49
@codecov-commenter
Copy link

Codecov Report

Merging #2312 (80a8ef1) into v1.x (5fd80a3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v1.x    #2312   +/-   ##
=======================================
  Coverage   20.57%   20.57%           
=======================================
  Files         137      137           
  Lines       15687    15687           
=======================================
  Hits         3227     3227           
  Misses      12154    12154           
  Partials      306      306           

Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this already in main?

@rach-id
Copy link
Member Author

rach-id commented Aug 18, 2023

Yes, and I cherry picked the commit. I forgot to put the megify tag so it wasnt ported to v1.x

@rach-id rach-id merged commit e61738f into celestiaorg:v1.x Aug 18, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants