Record validator set during EndBlock for QGB orchestrator
#232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
commented
Mar 7, 2022
Comment on lines
+49
to
+52
| // Confirms: k.GetDataCommitmentConfirmsByCommitment( | ||
| // sdk.UnwrapSDKContext(ctx), | ||
| // request.Commitment, | ||
| // ), |
There was a problem hiding this comment.
commented this out for now until we figure out an ideal way of querying.
evan-forbes
changed the title
EndBlockEndBlock for QGB orchestrator
adlerjohn
reviewed
Mar 7, 2022
| @@ -1,7 +1,26 @@ | |||
| syntax = "proto3"; | |||
| package qgb; | |||
|
|
|||
| import "gogoproto/gogo.proto"; | |||
There was a problem hiding this comment.
Nit, but can you format the alignment for this file, and add a newline at the end?
rach-id
approved these changes
Mar 7, 2022
| message GravityNonces { | ||
| // the nonce of the last generated validator set | ||
| uint64 latest_valset_nonce = 1; | ||
| } |
There was a problem hiding this comment.
Can you add a new line here ? that's how it is in Github :D
| uint64 nonce = 1; | ||
| repeated BridgeValidator members = 2 [(gogoproto.nullable) = false]; | ||
| uint64 height = 3; | ||
| } |
| sdkerrors "github.com/cosmos/cosmos-sdk/types/errors" | ||
| ) | ||
|
|
||
| // EndBlocker is called at the end of every block |
There was a problem hiding this comment.
Will we be sending the data root of every block ? not a commitment over a set of data roots?
|
@evan-forbes Can we merge this so that I include this stuff for the tests also ? Thanks |
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
May 9, 2022
…org#232) * add valset and params * create new val set request if the voting power has changed enough at the end of the block * comment out broken query method we don't strictly need yet * delete some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds changes needed to record the validator set at the end of the block. We technically don't need this for MVP, as the orchestrator could keep track of changes to the validator set and submit
ValsetConfirms on its own. However, we will need this for slashing in the future, and its makes writing the orchestrator significantly easier, so adding it now.