feat: cherry-pick changes to the user pkg #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR consolidates a lot of our testing infrastructure using the new signer instead of the old
This moves BondDemon to the appconsts package. This is a commonly used constant especially for clients submitting messages. They shouldn't need to import the entire app package just to use this constant. By doing this we also remove a duplicate bondDenom that was created to avoid import cycles
evan-forbes
approved these changes
Aug 25, 2023
Codecov Report
@@ Coverage Diff @@
## v1.x #2362 +/- ##
=======================================
Coverage ? 20.55%
=======================================
Files ? 138
Lines ? 15736
Branches ? 0
=======================================
Hits ? 3235
Misses ? 12194
Partials ? 307 |
rootulp
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.