Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds msg server data commitment test for QGB module #242

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Mar 11, 2022

Adds a simplified integration test for data commitments in QGB module

@rach-id rach-id self-assigned this Mar 11, 2022
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

nice!

Do we have plans to add queries for the two new keeper getters? I don't think we need specific queries for them, so I don't really see the need atm, just curious.

@rach-id
Copy link
Member Author

rach-id commented Mar 11, 2022

@evan-forbes Only one is added. The other was just copied from another file to its right place.
I think we might need the new one when doing tests (I used it today to double check). So yes, I guess we can leave it.

@rach-id rach-id merged commit 8209e23 into celestiaorg:qgb-integration Mar 11, 2022
@rach-id rach-id deleted the adds_msg_server_data_commitment_test branch March 11, 2022 19:06
rach-id added a commit to rach-id/celestia-app that referenced this pull request May 9, 2022
* adds handler test

* adds events check for handler test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants