Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: backport the overview document #2447

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Sep 7, 2023

Overview

This PR backports the overview document changes to v1.x

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

rach-id and others added 3 commits September 7, 2023 18:58
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!--
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue.
-->

Closes: celestiaorg#1946

## Checklist

<!--
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

---------

Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
(cherry picked from commit 9de969c)
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!--
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue.
-->

Applies remaining feedback from reviewers

## Checklist

<!--
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

(cherry picked from commit 2ed00dc)
## Overview
- Update `dataCommitment` struct to reflect new changes:
celestiaorg/blobstream-contracts#154

(cherry picked from commit 63915bf)
@rach-id rach-id added documentation Improvements or additions to documentation x/qgb labels Sep 7, 2023
@rach-id rach-id requested a review from rootulp September 7, 2023 16:59
@rach-id rach-id self-assigned this Sep 7, 2023
@celestia-bot celestia-bot requested a review from a team September 7, 2023 16:59
@rach-id rach-id enabled auto-merge (rebase) September 7, 2023 16:59
@rach-id rach-id merged commit 6a398ed into celestiaorg:v1.x Sep 8, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants