Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: introduce proto breakage detector #2671

Merged
merged 5 commits into from Oct 16, 2023
Merged

ci: introduce proto breakage detector #2671

merged 5 commits into from Oct 16, 2023

Conversation

cmwaters
Copy link
Contributor

Still thinking about whether we should enable this on main

@celestia-bot celestia-bot requested a review from a team October 12, 2023 10:04
@cmwaters cmwaters marked this pull request as draft October 12, 2023 10:05
@cmwaters cmwaters marked this pull request as ready for review October 12, 2023 10:50
rootulp
rootulp requested changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] do we intend on making this a required CI check after it merges?

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.github/workflows/protobuf.yml Outdated Show resolved Hide resolved
.github/workflows/protobuf.yml Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@cmwaters
Copy link
Contributor Author

do we intend on making this a required CI check after it merges?

Yeah I think we should

@cmwaters @rootulp
Apply suggestions from code review
b518d40 
Co-authored-by: Rootul P <rootulp@gmail.com>
@celestia-bot celestia-bot requested a review from a team October 13, 2023 10:02
@cmwaters cmwaters requested a review from rootulp October 13, 2023 12:14
@cmwaters cmwaters merged commit 5094399 into v1.x Oct 16, 2023
25 checks passed
@cmwaters cmwaters deleted the cal/proto-breakage-ci branch October 16, 2023 11:16
cmwaters added a commit that referenced this pull request Oct 16, 2023
@cmwaters @rootulp
ci: introduce proto breakage detector (#2671)
ac9a4ea 
Co-authored-by: Rootul P <rootulp@gmail.com>
@cmwaters cmwaters mentioned this pull request Oct 16, 2023
Merged
cmwaters added a commit that referenced this pull request Oct 23, 2023
@cmwaters
ci: introduce proto breakage detector (#2671) (#2684)
35074ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@cmwaters cmwaters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cmwaters @rootulp @evan-forbes