Adds Ethereum signatures verification + refactor the orchestrator/relayer for testing #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## qgb-integration #314 +/- ##
==================================================
Coverage ? 14.12%
==================================================
Files ? 50
Lines ? 9196
Branches ? 0
==================================================
Hits ? 1299
Misses ? 7806
Partials ? 91 Continue to review full report at Codecov.
|
rach-id
changed the title
|
@evan-forbes I think this PR can be merged so that the upcoming changes can be tracked in separate PRs. |
evan-forbes
approved these changes
Apr 19, 2022
adlerjohn
reviewed
Apr 19, 2022
| @@ -1,4 +1,7 @@ | |||
| 4d63.com/gochecknoglobals v0.0.0-20201008074935-acfc0b28355a/go.mod h1:wfdC5ZjKSPr7CybKEcgJhUOgeAQW1+7WcyK8OvUilfo= | |||
There was a problem hiding this comment.
why is go.sum being modified?
There was a problem hiding this comment.
because we keep adding new dependencies etc, I guess
This was
linked to
issues
Apr 25, 2022
rach-id
added a commit
to rach-id/celestia-app
that referenced
this pull request
May 9, 2022
…ayer for testing (celestiaorg#314) * temporary disables listening for valsets and query for latest valset instead * app client listening for arbitrary events for valsets * temporary disable signatures for testing * temporarily disable threshold checks for relayer * update count in end blocker * fixes orchestrator listening to valset events * fix orchestrator signatures + enables checks on msg_server + makes bridgeId a const * fixes signature tests + adds new checks * adds todo * remove unnecessary comment * adds todo * adds todo * moves the signer outside of the NewAppClient * cosmetics * updates singe node script to only create one validator * uncomments the threshold for querying two third data commitment confirms * linter checks + cosmetics fixes * cosmetics * removes todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.